dont try to push pod if its a canary release #123
Conversation
| apply(auto) { | ||
| auto.hooks.canary.tap(this.name, () => { |
There was a problem hiding this comment.
This looks good to me. Only thought is if it would make sense just to early return if we release is undefined and log? Just trying to think if there are any other use cases where afterShipIt would be invoked but not have an actual release.
There was a problem hiding this comment.
AFAIK theres only 3 flows, release, prerelease and canary? and the first two we do have tags, so if we get the canary hook called, i can skip even hitting the release API since i know it wont have a tag
There was a problem hiding this comment.
i updated it to log an error if a release isnt found, rather than exploding, since we should have a release in the other scenarios, if it failed creating the release, auto would die before this plugin runs
…e end of the loop
|
/canary |
Added a flag to track if the canary hook is called, rather than spend time polling when we know there will be no tag/release
📦 Published PR as canary version:
0.3.1--canary.123.4401Try this version out locally by upgrading relevant packages to 0.3.1--canary.123.4401